Skip to content

Declared app media types for kargo#2

Open
lukenovak wants to merge 1 commit into
masterfrom
kargo-enable-app-based-requests
Open

Declared app media types for kargo#2
lukenovak wants to merge 1 commit into
masterfrom
kargo-enable-app-based-requests

Conversation

@lukenovak

@lukenovak lukenovak commented Jun 15, 2026

Copy link
Copy Markdown

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

Summary by CodeRabbit

  • New Features
    • Updated Kargo bidder to explicitly support banner, video, and native media types for enhanced media format compatibility.

@lukenovak lukenovak requested a review from jimee02 June 15, 2026 19:00
@lukenovak lukenovak added maintenence SAD PR done by members of the SAD team labels Jun 15, 2026
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: af0c4a84-7a5f-46a1-bad5-480144c5138e

📥 Commits

Reviewing files that changed from the base of the PR and between 5926c92 and ec4e9e3.

📒 Files selected for processing (1)
  • src/main/resources/bidder-config/kargo.yaml

Walkthrough

The meta-info.app-media-types field in the Kargo bidder configuration file is updated to explicitly list banner, video, and native as supported app media types.

Changes

Kargo Bidder Config

Layer / File(s) Summary
Add app-media-types allowlist
src/main/resources/bidder-config/kargo.yaml
Adds banner, video, and native entries under meta-info.app-media-types in the Kargo bidder YAML configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description uses the correct template format but leaves all substantive sections empty, providing no context, rationale, test plan, or quality assurance details. Fill in the 'What's the context?', 'Rationale behind the change', 'Test plan', and 'Quality check' sections with concrete details about the changes and testing approach.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: declaring app media types for the kargo adapter.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kargo-enable-app-based-requests

Comment @coderabbitai help to get the list of available commands and usage tips.

@lukenovak lukenovak requested a review from andyrusiecki June 24, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenence SAD PR done by members of the SAD team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant