Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I read python scripts you written. I'm glad that more members use python language.
I will suggest four points.
1. if you could do, you should hide user name
from
to
2. Write in all lowercase English. When you run scripts, it's hard to type file name written in Japanese.
3. Use "/" instead of "\". Only Windows OS use backquotes. if you want to type file path, you could choose several ways
The third one is the simplest.
4. Include image files in your project
In addition, you should use relative paths instead of absolute ones.
if you do, every member could run these scripts. (only if they have installed the opencv library)