feat(glob): split base dir on path component to avoid walking from cwd#991
Open
SAY-5 wants to merge 1 commit into
Open
feat(glob): split base dir on path component to avoid walking from cwd#991SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #740.
load_from_globpreviously split the glob at the first*character, which can leave the base directory ending mid-component (e.g.templ*/*.htmlyielded basetempl) and makes globwalk walk from the cwd. This splits at the last slash before the first wildcard so the base directory is always a real path component.Keats said "I'd take a PR for that!" in #740 (comment). Added a regression test
glob_base_dir_splits_on_path_component; all existing glob tests still pass.