Improve Display Impl - Each ValidationError should be on its own line#235
Open
aarashy wants to merge 1 commit intoKeats:masterfrom
Open
Improve Display Impl - Each ValidationError should be on its own line#235aarashy wants to merge 1 commit intoKeats:masterfrom
aarashy wants to merge 1 commit intoKeats:masterfrom
Conversation
Keats
approved these changes
Oct 15, 2022
Author
|
Hi, thanks for the approval - the issue with CI seems unrelated to this PR, right? |
Owner
|
It seems unrelated yes |
Author
|
Would you like me to re-run the CI or will you merge this later? |
Owner
|
That's fine to leave like this, I'll merge for the next release |
|
is this going to be merged? |
Owner
|
The concept probably, but ideally there will be an error rewrite for the next version to make it simpler. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current impl for Display doesn't break newlines frequently enough.
The display output of the list variant of
ValidationErrorsKindcurrently looks like the following:It only breaks line when the top-level field of the
ValidationErrorschanges. I would prefer for it to look like the following:It seems pretty clear that separate field-level errors belong on their own line - having multiple on the same line always looks bad. Having multiple line-breaks when the top-level field changes doesn't feel like a regression either, but we could remove the existing
writeln!call if we wanted a maximum of 1 new line after every error display.