Expose validator constraints to end-users using a new trait#318
Open
kyrias wants to merge 3 commits intoKeats:masterfrom
Open
Expose validator constraints to end-users using a new trait#318kyrias wants to merge 3 commits intoKeats:masterfrom
kyrias wants to merge 3 commits intoKeats:masterfrom
Conversation
Signed-off-by: Johannes Löthberg <johannes.loethberg@elokon.com>
Signed-off-by: Johannes Löthberg <johannes.loethberg@elokon.com>
Contributor
Author
|
Ping. |
Owner
|
Thanks for the ping I had forgotten about it. I'll look at it next week. |
Keats
reviewed
Jul 25, 2024
Owner
Keats
left a comment
Keats
left a comment
There was a problem hiding this comment.
It's a bit invasive and requires keeping the structs updated to match the parameters of the validators. Do we need the constraints to be fully typed? I'm guessing it's going to be passed to the frontend or some other service anyway in most cases
Can we somehow derive it from the darling attributes directly without having to add to the constraints on each function?
| code: Option<Cow<'static, str>>, | ||
| function: Cow<'static, str>, | ||
| }, | ||
| } |
Owner
There was a problem hiding this comment.
Do we need custom types VS a hashmap of all the args? We could build it in the derive macro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-implements #238 after the derive macro rewrite.