Remove dependency on unic-ucd-common by using std::char::is_control#366
Merged
Keats merged 1 commit intoKeats:masterfrom Jan 30, 2025
mmalecot:master
Merged
Remove dependency on unic-ucd-common by using std::char::is_control#366Keats merged 1 commit intoKeats:masterfrom mmalecot:master
Keats merged 1 commit intoKeats:masterfrom
mmalecot:master
Conversation
Keats
approved these changes
Jan 30, 2025
Owner
|
Nice thanks, are you using that validator? That's the one I didn't know whether it was used by anyone at all |
Contributor
Author
|
Yes, I use it to ensure that a string contains only single-line text for example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking whether a character is a control character is already present in the
std, so no external dependency is required and theunicfeature no longer needs to exist (or at least is built-in).