Add convenience with_error function to ValidationErrors struct#368
Open
3lpsy wants to merge 1 commit intoKeats:masterfrom
Open
Add convenience with_error function to ValidationErrors struct#3683lpsy wants to merge 1 commit intoKeats:masterfrom
3lpsy wants to merge 1 commit intoKeats:masterfrom
Conversation
3lpsy
changed the title
3lpsy
changed the title
Keats
approved these changes
Feb 9, 2025
Author
|
Sorry @Keats, I accidentally requested a re-review. There's no changes so one is not needed. Is there anything else I need to do get merged? Thanks! |
Owner
|
Nothing, i'll merge it when I make a new release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simply adds a convenience method so you can chain when adding errors to
ValidationErrors. It just callsaddand returnsself.