Conversation
…onciliation crashes
🧹 PR Environment Cleaned UpThe PR environment has been successfully deleted. Deleted Resources:
All resources have been cleaned up and will no longer incur costs. |
ℹ️ No PR Environment to Clean UpNo PR environment was found for this PR. This is expected if:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two production errors fired 10 minutes ago on
/workflows/:workflowId:NotFoundError: removeChild ... not a child of this nodeNotFoundError: insertBefore ... not a child of this nodeBoth stack traces are 100% inside
react-dom-client.production.js(no app code). Sametrace_id, same render commit, 8ms apart. Affected user: Chrome Mobile on Android 10, localezh-CN, timezoneAsia/Shanghai— classic fingerprint of Chrome's auto-translation mutating the DOM behind React's back.Chrome/Google Translate replaces text nodes with
<font>wrappers. When React later triesparent.removeChild(child)/parent.insertBefore(newNode, ref), the node isn't where React left it, so the browser throwsNotFoundError. The reconciler can't recover and the editor unmounts.Fix
Wrap the workflow editor subtree in a
translate="no"div. Auto-translators skip the subtree, React's DOM assumptions hold.display: contentskeeps the wrapper transparent to layout.The marketing / hub / listing pages remain translatable, so SEO and accessibility for non-English users aren't affected.
Sentry references
Fixes KEEPERHUB-PRODUCTION-C
Fixes KEEPERHUB-PRODUCTION-D