Skip to content

fix: KEEP-288 guard onConnectEnd node creation with connectionState.isValid #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suisuss merged 1 commit into from
Apr 21, 2026
Merged

fix: KEEP-288 guard onConnectEnd node creation with connectionState.isValid #905

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 7 additions & 20 deletions components/workflow/workflow-canvas.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import {
ConnectionMode,
type FinalConnectionState,
MiniMap,
type Node,
type NodeMouseHandler,
Expand Down Expand Up @@ -562,30 +563,16 @@ export function WorkflowCanvas() {
);

const onConnectEnd = useCallback(
(event: MouseEvent | TouchEvent) => {
(event: MouseEvent | TouchEvent, connectionState: FinalConnectionState) => {
if (!connectingNodeId.current) {
return;
}

// Get client position first
const { clientX, clientY } = getClientPosition(event);

// For touch events, use elementFromPoint to get the actual element at the touch position
// For mouse events, use event.target as before
const target =
"changedTouches" in event
? document.elementFromPoint(clientX, clientY)
: (event.target as Element);

if (!target) {
connectingNodeId.current = null;
return;
}

const isNode = target.closest(".react-flow__node");
const isHandle = target.closest(".react-flow__handle");

if (!(isNode || isHandle)) {
// isValid === null: pointer never entered a handle's connection radius (pane drop).
// true: valid connection -- onConnect already created the edge.
// false: over a handle that rejected the drop -- do nothing.
if (connectionState.isValid === null) {
const { clientX, clientY } = getClientPosition(event);
const { adjustedX, adjustedY } = calculateMenuPosition(
event,
clientX,
Expand Down
Loading