Conversation
🧹 PR Environment Cleaned UpThe PR environment has been successfully deleted. Deleted Resources:
All resources have been cleaned up and will no longer incur costs. |
ℹ️ No PR Environment to Clean UpNo PR environment was found for this PR. This is expected if:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
buildjob inpr-checks.ymlhas failed on every Dependabot-authored PR since KEEP-266 + KEEP-267 landed (2026-04-17) because the job requires AWS/ECR credentials that Dependabot workflow runs cannot access.Fix:
.github/workflows/pr-checks.yml: skipConfigure AWS credentialsandLogin to AWS ECRsteps whengithub.actor == 'dependabot[bot]'. ECR_REGISTRY env var then arrives empty at the bake step.docker-bake.hcl: guardtags,cache-from,cache-toon theapptarget withECR_REGISTRY != "". Empty registry -> no tags, no cache, pure Dockerfile validation build.Only the
apptarget is modified because the PR CI build job only builds theapptarget. Deploy/release workflows that build the other targets (migrator,workflow-runner, etc.) always have ECR credentials, so those targets are untouched.Root cause
Before KEEP-267, PR CI ran
pnpm build(no AWS needed) and Dependabot PRs worked. KEEP-267 replaced it withdocker buildx bake+ ECR cache, which requiressecrets.TO_AWS_ACCESS_KEY_ID/TO_AWS_SECRET_ACCESS_KEY— both scoped to thestagingenvironment. GitHub deliberately does not expose Actions secrets or environment secrets to Dependabot workflow runs, so both references resolve to empty strings,aws-actions/configure-aws-credentials@v6exhausts its provider chain, and the job fails withCould not load credentials from any providers.Regular (human-authored) PRs are unaffected — they have normal environment access and the
buildjob passes (e.g., #905).First visible failure: #889 (dompurify bump in docs-site). Ticket: KEEP-293.
Tradeoff
Dependabot validation runs without registry build cache -- full cold build, ~5-10 min. Acceptable for correctness.
Test plan
stagingstagingbuildcheck passes without any AWS creds being granted to Dependabot