Skip to content

Imrove CI/CL, add more unit tests, improve documentation#112

Merged
houman1359 merged 18 commits into
developfrom
iss_CICL
Oct 6, 2025
Merged

Imrove CI/CL, add more unit tests, improve documentation#112
houman1359 merged 18 commits into
developfrom
iss_CICL

Conversation

@houman1359

@houman1359 houman1359 commented Oct 6, 2025

Copy link
Copy Markdown
Collaborator

Description

Brief description of the changes in this PR.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring

Testing

  • Tests pass locally
  • New tests added for new functionality
  • All existing tests pass
  • Manual testing completed

Checklist

  • Code follows the project's coding standards
  • Self-review of the code completed
  • Code is properly commented
  • Documentation updated (if applicable)
  • No new warnings or errors introduced

Related Issues

Closes #(issue number)

Additional Notes

Any additional information that reviewers should know.

- Fix CNN2P2 test: Add in_channels=3 parameter for RGB input
- Fix PersistentHookManager: Initialize count before incrementing
- All model tests now passing (16/16 passed, 1 skipped)
- Replace outdated classes with current experiment configs
- 7 tests passing, matches GeneralAlignmentExperiment API
- Use get_metric() instead of direct imports
- 15 tests passing with registry pattern
- Add _arxiv/, drafts/, *.bak, *.old to .gitignore
- Remove old test backups and archived code from tracking
- Files remain on disk but won't be tracked in git
@houman1359 houman1359 merged commit fa2daef into develop Oct 6, 2025
2 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant