[fix] bid form 사이징 오류 수정#486
Merged
Merged
Conversation
Contributor
검토자 가이드입찰 양식 전환 높이 및 반응형 입력 필드 크기를 조정하고, 라벨 정렬을 개선하며, 입찰자 아바타와 테이블 행의 테두리를 표준화하고 테이블 타임라인 표시기 높이를 조절합니다. 파일 수준 변경 사항
연결된 이슈에 대한 평가
관련 가능성이 있는 이슈
팁 및 명령어Sourcery와 상호작용하기
경험 사용자 지정대시보드에 접속하여 다음을 수행하세요:
도움 받기
Original review guide in EnglishReviewer's GuideAdjusts bid form transition height and responsive input sizing, refines label alignment, and standardizes borders in bidder avatars and table rows while tweaking the table’s timeline indicator height. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
안녕하세요 @geumyoung00님 - 변경 사항을 검토했습니다. 피드백입니다:
- BidFormInput에서 정적 클래스 문자열 주위에 있는 중복된 cn() 래퍼를 제거하는 것을 고려해 보세요. 조건부 로직이 없을 때는 일반 className을 사용하는 것이 더 간단합니다.
- BidderAvatar와 BidTableRow 모두에서
border-1 border-primary-100을 중복해서 사용하셨습니다. 스타일 일관성을 유지하기 위해 공유 유틸리티 또는 상수로 추출하세요. border-1이 Tailwind 설정에 정의되어 있는지 확인하세요 (기본 1px 유틸리티는 단순히border입니다). 그렇지 않으면 런타임에 스타일이 누락될 수 있습니다.
AI 에이전트용 프롬프트
Please address the comments from this code review:
## Overall Comments
- Consider removing the redundant cn() wrapper around a static class string in BidFormInput—using a plain className is simpler when there’s no conditional logic.
- You’ve duplicated `border-1 border-primary-100` in both BidderAvatar and BidTableRow—extract that into a shared utility or constant to keep the style consistent.
- Verify that `border-1` is defined in your Tailwind config (the default 1px utility is just `border`), otherwise you might end up with missing styles at runtime.
## Individual Comments
### Comment 1
<location> `apps/web/src/components/auction-detail/bid-table/row.tsx:39` </location>
<code_context>
<div
className={cn(
- 'ml-3 flex w-full rounded-sm bg-white py-2.5 text-sm text-neutral-600 opacity-90',
+ 'border-1 border-primary-100 ml-3 flex w-full rounded-sm bg-white py-2.5 text-sm text-neutral-600 opacity-90',
isAuthor &&
'border-1 border-primary-500 text-primary-600 shadow-primary-300 font-bold opacity-100 shadow-sm'
</code_context>
<issue_to_address>
Adding a border to all rows may conflict with conditional author styling.
Check that CSS specificity prevents double borders or color conflicts when both base and author row styles are applied.
</issue_to_address>제가 더 유용해질 수 있도록 도와주세요! 각 댓글에 👍 또는 👎를 클릭해 주시면 피드백을 사용하여 리뷰를 개선하겠습니다.
Original comment in English
Hey @geumyoung00 - I've reviewed your changes - here's some feedback:
- Consider removing the redundant cn() wrapper around a static class string in BidFormInput—using a plain className is simpler when there’s no conditional logic.
- You’ve duplicated
border-1 border-primary-100in both BidderAvatar and BidTableRow—extract that into a shared utility or constant to keep the style consistent. - Verify that
border-1is defined in your Tailwind config (the default 1px utility is justborder), otherwise you might end up with missing styles at runtime.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider removing the redundant cn() wrapper around a static class string in BidFormInput—using a plain className is simpler when there’s no conditional logic.
- You’ve duplicated `border-1 border-primary-100` in both BidderAvatar and BidTableRow—extract that into a shared utility or constant to keep the style consistent.
- Verify that `border-1` is defined in your Tailwind config (the default 1px utility is just `border`), otherwise you might end up with missing styles at runtime.
## Individual Comments
### Comment 1
<location> `apps/web/src/components/auction-detail/bid-table/row.tsx:39` </location>
<code_context>
<div
className={cn(
- 'ml-3 flex w-full rounded-sm bg-white py-2.5 text-sm text-neutral-600 opacity-90',
+ 'border-1 border-primary-100 ml-3 flex w-full rounded-sm bg-white py-2.5 text-sm text-neutral-600 opacity-90',
isAuthor &&
'border-1 border-primary-500 text-primary-600 shadow-primary-300 font-bold opacity-100 shadow-sm'
</code_context>
<issue_to_address>
Adding a border to all rows may conflict with conditional author styling.
Check that CSS specificity prevents double borders or color conflicts when both base and author row styles are applied.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
dolmeengii
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 풀 리퀘스트 제안
closes #481
📋 작업 내용
🔧 변경 사항
주요 변경 사항을 요약해 주세요.
📸 스크린샷 (선택 사항)
수정된 화면 또는 기능을 시연할 수 있는 스크린샷을 첨부해 주세요.
📄 기타
추가적으로 전달하고 싶은 내용이나 특별한 요구 사항이 있으면 작성해 주세요.
Sourcery 요약
입찰 양식 및 입찰 테이블 컴포넌트의 크기 및 스타일 불일치 수정
버그 수정:
max-height를 늘리고, 입력 필드 너비를 컨테이너를 채우도록 변경개선 사항:
Original summary in English
Summary by Sourcery
Fix sizing and styling inconsistencies in bid form and bid table components
Bug Fixes:
Enhancements: