Add cleanup in DocumentUrl tables when the content key changes.#869
Open
Add cleanup in DocumentUrl tables when the content key changes.#869
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a foreign key constraint violation that occurs when a content item's Key changes during import. The fix involves cleaning up entries in the umbracoDocumentUrl table before the key change is applied, preventing the constraint violation. Umbraco will repopulate the table with the new Key on save.
Key Changes:
- Introduced
ISyncDocumentUrlCleanerinterface andSyncDocumentUrlCleanerimplementation to handle DocumentUrl table cleanup - Added
OnKeyChangevirtual method inContentSerializerBaseto allow subclasses to respond to key changes - Integrated URL cleaning into
ContentSerializerwhen key changes are detected
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| uSync.Core/Documents/ISyncDocumentUrlCleaner.cs | New interface for document URL cleanup functionality |
| uSync.Core/Documents/SyncDocumentUrlCleaner.cs | Implementation that deletes DocumentUrl entries by document key using repository |
| uSync.Core/uSyncCoreBuilderExtensions.cs | Registers the URL cleaner as a singleton service |
| uSync.Core/Serialization/Serializers/ContentSerializerBase.cs | Adds virtual OnKeyChange method called when a content key changes |
| uSync.Core/Serialization/Serializers/ContentSerializer.cs | Overrides OnKeyChange to invoke URL cleaner and adds it as a dependency |
| uSync.Core/Serialization/Serializers/ContentTemplateSerializer.cs | Updates constructor to accept and pass the URL cleaner to base class |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Author
|
Warning (Breaking - changes the Constructor for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for umbraco/Umbraco-CMS#21131.
When a content item's Key changes during an import - Umbraco throws an ForeignKey exception because of the bindings to the
umbracoDocumentUrltable.This PR checks on key changes, and removes entries from that table (via the repository). - so the conflict doesn't happen.
On Save Umbraco puts new entries in the table with the new Key so this "should" be ok.