fix(sidebar): remove group header underline; eliminate drag-resize lag#658
Merged
fix(sidebar): remove group header underline; eliminate drag-resize lag#658
Conversation
- Remove border-b from GroupHeader in Sidebar.tsx - ResizeHandle: bypass React state during drag via direct DOM writes to sidebar.style.width and main.style.paddingLeft; disable padding transition while dragging; commit final width to React state on mouseup Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GroupHeaderからborder-b border-gray-700を除去Changes
src/components/layout/Sidebar.tsxsrc/components/layout/AppShell.tsxTechnical detail (drag-resize lag fix)
ドラッグ中のタイムラグの根本原因:
mousemoveのたびにsetWidth→ React state更新 → 再レンダリング発生transition-[padding] duration-300が毎ピクセルの変化をアニメーション対応:
sidebarRef.current.style.widthとmainRef.current.style.paddingLeftをDOM直接更新（React state変更なし）main.style.transition = 'none'でアニメーション抑制main.style.transition = ''でアニメーション復元setWidth(finalWidth)で一度だけ React state + localStorage に永続化Test plan
npx tsc --noEmit— 0 errorsnpm run lint— 0 errors/warningsnpm run test:unit— 334 files, 6319 tests passed🤖 Generated with Claude Code