-
Notifications
You must be signed in to change notification settings - Fork 2
Make the default value of n_features match the khiops core value
#545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
folmos-at-orange
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the changelog.
- KhiopsClassifier, KhiopsRegressor, KhiopsEncoder
db77fe2 to
819bb4f
Compare
|
| "field_separator": "\t", | ||
| "detect_format": False, | ||
| "header_line": True, | ||
| "max_constructed_variables": 1000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add n_features to the monotable tests (e.g. in test_parameter_transfer_classifier_fit_from_monotable_dataframe), in which case the expected max_constructed_variables should equal the value of n_features set in the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After exchanging with @folmos-at-orange on this PR or the other one related, the idea here is to verify the core parameter is set at its default value (1000) WITHOUT giving the optional input n_features.
Otherwise it would only be checking the correspondance between the value passed to the sklearn estimators and the value passed to the core
| "field_separator": "\t", | ||
| "detect_format": False, | ||
| "header_line": True, | ||
| "max_constructed_variables": 1000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idem above.
| "field_separator": "\t", | ||
| "detect_format": False, | ||
| "header_line": True, | ||
| "max_constructed_variables": 1000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idem above.
popescu-v
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor changes in the tests (see the comments).
Fixes #543
TODO Before Asking for a Review
main(ormain-v10)Unreleasedsection ofCHANGELOG.md(no date)index.html