Fix offline compiler handling: skip missing subtests and guard cl_khr…#2646
Open
bananAshkar wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Fix offline compiler handling: skip missing subtests and guard cl_khr…#2646bananAshkar wants to merge 1 commit intoKhronosGroup:mainfrom
bananAshkar wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR skips three compiler subtests (get_program_info_kernel_names, get_linked_program_info_kernel_names, get_program_info_mult_devices) when using offline/binary compilation, because they rely on source creation or multi-device behavior that does not match that path. It also changes the SPIR test main so that if cl_khr_spir is missing, the suite logs a clear skip and exits successfully instead of failing.