samplerlessReads: fix use_pitches test for devices with read_write images supported#2650
Open
karolherbst wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Conversation
karolherbst
force-pushed
the
fix/samplerless_read_write_pitches
branch
from
f79ed23 to
1644dbd
Compare
…ages supported The test specified a image_row_pitch and image_slice_pitch on the read_write image without a host_ptr or parent buffer. The read_write image doesn't get inialized like the read_only does, so it's fine to just reset the pitches back to 0 for its creation.
karolherbst
force-pushed
the
fix/samplerless_read_write_pitches
branch
from
1644dbd to
cb49713
Compare
Contributor
Author
|
Important clarification: this fixes the test when ran with |
Contributor
Author
|
Also looks like that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test specified a image_row_pitch on the read_write image without a host_ptr or parent buffer.
The read_write image doesn't get inialized like the read_only does, so it's fine to just reset image_row_pitch back to 0 for its creation.