Skip to content

remove automated formatting checks#253

Open
bashbaug wants to merge 2 commits intoKhronosGroup:mainfrom
bashbaug:remove-formatting-check
Open

remove automated formatting checks#253
bashbaug wants to merge 2 commits intoKhronosGroup:mainfrom
bashbaug:remove-formatting-check

Conversation

@bashbaug
Copy link
Copy Markdown
Contributor

We are removing the automated formatting checks before merging CI/CD changes in other repos, see for example: KhronosGroup/OpenCL-CLHPP@94eb4df.

But, we've already merged the CI/CD changes for this repo, so this PR is needed to remove the automated formatting checks.

Removing the automated formatting checks is is helpful for this repo especially since it has a large amount of auto-generated code that is already formatted consistently.

@EwanC
Copy link
Copy Markdown
Contributor

EwanC commented Jun 12, 2024

Although I don't object to removing the clang-format CI at the moment, should we create an issue to decide whether we want to clang-format the headers at some point in the future? A solution where we add clang-format to the existing header generation script, or clang-format headers as a step in the CMake generate build target I think would integrate into a development flow more effectively than the current manual step we are disabling.

It's not completely analogous but examples of these two solutions are:

@bashbaug bashbaug mentioned this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants