Open
Conversation
bashbaug
approved these changes
Jun 17, 2025
Contributor
Author
|
Will need to be reworked once #258 is merged, to accommodate the fact that the field my be missing if anonymous unions are not supported. |
Kerilk
force-pushed
the
icd_union
branch
2 times, most recently
from
c0cc390 to
11dbdf4
Compare
Contributor
Author
|
This one should be ready now. |
Contributor
Author
|
|
Contributor
|
Discussed briefly in the March 17th teleconference. The changes LGTM and seem pretty low-risk, but it might be good to have at least one icd2 implementer give it a look too, though - @karolherbst or @pjaaskel maybe? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use _icd2_tag fields from KhronosGroup/OpenCL-Headers#280.