Fix test/transcoding/dbginfo-bug-on-bool-converts.ll test expectations#3879
Open
aobolensk wants to merge 1 commit into
Open
Fix test/transcoding/dbginfo-bug-on-bool-converts.ll test expectations#3879aobolensk wants to merge 1 commit into
aobolensk wants to merge 1 commit into
Conversation
llvm/llvm-project#209232 fixed the SPIR-V backend's selectIToF to preserve signedness (sitofp i1 true was miscompiled as 1.0 instead of -1.0), so the select now produces -1 rather than 1
Contributor
Author
|
llvm-23 is still used on CI verification runs |
Member
Indeed, we're waiting for new apt.llvm.org packages to appear before merging #3864 |
Contributor
|
Can we merge this PR now? Since incoming PRs depend on this for CIs :) |
Contributor
Author
I don't mind, but I don't have sufficient permissions to merge :) |
Contributor
Author
And they are kind of bundled together with #3864 (to actually fix all issues we have on the main llvm branch) |
Contributor
|
@svenvh Can you merge this PR so that we can at least unblock all the in-tree CIs? |
Member
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
llvm/llvm-project#209232 fixed the SPIR-V backend selectIToF to preserve signedness (sitofp i1 true was miscompiled as 1.0 instead of -1.0), so the select now produces -1 rather than 1