Error handling for malformed SPIRV input#3900
Open
maarquitos14 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further hardening of the translator against malformed input to prevent crashes. Specifically, this PR:
SPIRVFunction::decode()for opcodes that don't belong in function scope.Decoder.getEntry()inSPIRVFunction::decodeBB()because it can returnnullptrand it was otherwise dereferenced down the line.5 new lit tests are added that were crashing before this patch. These new tests are a bit special, they need to feed deliberately malformed SPIR-V to the translator, including opcodes that don't exist, instructions in the wrong scope or truncated streams. Since spirv-as normally validates its input, the tests use its
!<integer>syntax to inject raw 32-bit words directly into the binary output, bypassing validation. For example,!75535emits the raw word(1<<16)|9999, which encodes a single-word instruction with unknown opcode 9999. Care must be taken with placement:!words after variadic instructions (like OpTypeFunction) get absorbed as extra operands rather than emitted as standalone instructions.