spirv-val: Combine Image Coordinate checks#6494
Merged
alan-baker merged 2 commits intoJan 19, 2026
Merged
Conversation
alan-baker
approved these changes
Jan 15, 2026
Contributor
Author
|
These are failing in the |
alan-baker
approved these changes
Jan 17, 2026
alan-baker
left a comment
alan-baker
left a comment
Contributor
There was a problem hiding this comment.
Validation ok, I'll leave opt review to @s-perron
s-perron
approved these changes
Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This originally came out of https://gitlab.khronos.org/spirv/SPIR-V/-/issues/905 where we found a driver that crashed passing it 16-bit floats as the coordinate
I tried to combine the logic and went through each type ... I am not sure why/if there is a difference between Vulkan/OpenCL with respect to allowing Float vs Int (but found 1 that we have active tests for https://gitlab.khronos.org/spirv/SPIR-V/-/issues/908) ... the other is
OpImageRead/OpImageWrite, those were being validated incorrectly according to the spec