Use ASSERT_STREQ for testing ExtractSourceFromModule results#6600
Open
OPNA2608 wants to merge 1 commit into
Open
Use ASSERT_STREQ for testing ExtractSourceFromModule results#6600OPNA2608 wants to merge 1 commit into
OPNA2608 wants to merge 1 commit into
Conversation
|
|
alan-baker
approved these changes
May 28, 2026
Contributor
|
Likely needs a rebase. |
In case of a mismatch, ASSERT_STREQ actually prints both strings. Example:
/build/source/test/tools/objdump/extract_source_test.cpp:223: Failure
Expected equality of these values:
resStr.c_str()
Which is: "diovmoc etup}{)("
"void compute(){}"
auto-merge was automatically disabled
May 31, 2026 12:57
Head branch was pushed to by a user without write access
OPNA2608
force-pushed
the
fix/test-objdump-streq
branch
from
May 31, 2026 12:57
b354e4b to
8a73b30
Compare
Author
|
Rebased on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of a mismatch,
ASSERT_STREQactually prints both strings. Example:This makes it easier to see that SPIRV-Tools has a similar issue as KhronosGroup/glslang#4145, where parsing on big-endian gives either seemingly no/incomplete results, or results where strings are partially reversed.