Support '+' separator in feature depends#2622
Merged
Merged
Conversation
The Vulkan dependency syntax defines '+' as logical AND and ',' as logical OR. The depends attribute on <feature> elements always intends AND semantics, but historically used ',' as the separator. Future XML will use the correct '+' separator. Switch from tokenize(..., ",") to tokenizeAny(..., ",+") so the parser accepts both forms, remaining backward-compatible with current XML while being forward-compatible with the corrected XML. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Thanks for this little adjustment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Vulkan dependency syntax defines '+' as logical AND and ',' as logical OR.
The
dependsattribute on<feature>elements always intends AND semantics,but historically used ',' as the separator. Future XML corrections will use
the proper '+' separator (see https://gitlab.khronos.org/vulkan/vulkan/-/issues/4912).
Switch from
tokenize(..., ",")totokenizeAny(..., ",+")so the parseraccepts both forms — backward-compatible with current XML, forward-compatible
with the corrected XML.
▎ GenAI disclosure: Draft assisted by Claude (claude-sonnet-4-6[1m], Anthropic, commercial SaaS — Claude Code CLI).