-
Notifications
You must be signed in to change notification settings - Fork 810
Update iOS build and CI to support standardization of FindVulkan.cmake #1500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SRSaunders
wants to merge
12
commits into
KhronosGroup:main
Choose a base branch
from
SRSaunders:ios-build-tolerance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2aa678a
Update iOS build and CI to support future standarization of FindVulka…
SRSaunders b84c788
Update and simplify iOS build instructions using cmake toolchain file
SRSaunders 0fa6ee8
Prevent Apple builds from always compiling the shaders for new config…
SRSaunders 456f382
Set VK_LAYER_KHRONOS_validation to optional in case layer not availab…
SRSaunders eeac24c
Updated CMakeLists and build.adoc copyright dates to 2026
SRSaunders c51cfb6
Add copyright notice to ios.cmake toolchain file
SRSaunders c67172f
Update to Vulkan SDK 1.4.341.1 for iOS CI builds to match project
SRSaunders f23a66e
Search for Vulkan_Layer_VALIDATION on iOS if not defined or found by …
SRSaunders 87a4e8f
Update copyright notice in ios.cmake file
SRSaunders 801087e
Check some samples to ensure device is defined - avoid crash on exit
SRSaunders 643796a
One more time - update the ios.cmake license declaration and reference
SRSaunders bd8b673
Revert ios.cmake license declaration back to Apache-2.0
SRSaunders File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| #[[ | ||
|
|
||
| Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. | ||
| Copyright (c) 2026, Stephen Saunders | ||
|
|
||
| SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| Licensed under the Apache License, Version 2.0 the "License"; | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
|
|
||
| ------------------------------------------------------------------------ | ||
|
|
||
| Co-Authored-By: (Qualcomm) Giancane, Francesco <fgiancan@qti.qualcomm.com> | ||
| Co-Authored-By: Stephen Saunders | ||
|
|
||
| ]] | ||
|
|
||
| # As per upstream CMake recommendation in https://gitlab.kitware.com/cmake/cmake/-/issues/27661 | ||
| # for iOS we can use a toolchain file to set up search paths and simplify the command line | ||
| # | ||
| # iOS/setup-env.sh will first take care of defining the VULKAN_SDK environment variable | ||
| # Toolchain file shall define: | ||
| # - Target system name to iOS | ||
| # - Minimum deployment target to iOS 16.3 | ||
| # - Build only the active arch for devices and simulator | ||
| # - Export the $ENV{VULKAN_SDK} variable to `CMAKE_FIND_ROOT_PATH` | ||
| # | ||
| # Note: We define CMAKE_FIND_ROOT_PATH to locate the iOS Vulkan frameworks from the SDK. | ||
| # We don't define CMAKE_OSX_SYSROOT here since we need to build for both physical devices | ||
| # (iphoneos) and simulator (iphonesimulator) - do that instead on the cmake command line. | ||
|
|
||
| set(CMAKE_SYSTEM_NAME iOS) | ||
| set(CMAKE_OSX_DEPLOYMENT_TARGET 16.3) | ||
| set(CMAKE_XCODE_ATTRIBUTE_ONLY_ACTIVE_ARCH YES) | ||
| set(CMAKE_FIND_ROOT_PATH "$ENV{VULKAN_SDK}") | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SRSaunders can you please accept this change? Legal team reviewed this and requested the copyright to be stated like this, according to Apache-2.0 license.
Otherwise, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but if it's not a contribution, then what is it? I am not sure I understand the intent of this change from your legal folks. Can you clarify what this means?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From Apache 2 license:
Last line in the license explains the "Not a Contribution" usage in copyrights. I relayed your question to the Legal team to provide more clarity here.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I am not a maintainer on this project so I cannot say whether this can be accepted or not. You will have to ask @gpx1000 about that.
However, based on the above text, "Contribution" and "submitted" are exactly what we are doing here, which is described by "communication sent to the Licensor or its representatives, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Licensor for the purpose of discussing and improving the Work".
The next clause "but excluding communication that is conspicuously marked or otherwise designated in writing by the copyright owner as "Not a Contribution." means that we should NOT include in the license any further improvements discussed by you if you mark a new communication as such. Note the exact wording here: the license talks about marking "communication as Not a Contribution", not the licensed work itself. That means in future discussion that you could mark a new idea as Not a Contribution and it would not be incorporated in the code and not included in the original license. That would be more reasonable.
However, these kinds of communication clauses are typically put in licensing agreements when the IP licensing is 1-way only, with no follow-on discussion desired by the licensee. That approach is not very typical of open source where ongoing contribution and discussion is typically welcomed and encouraged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SRSaunders thanks for all the clarifications. As you can imagine, I am not a legal person myself so I am following what folks from legal team told me to do. Please bear with me some more time to see if I can get some more information and/or inputs on how we can better address this.
@gpx1000 since you're maintainer here, any history/inputs/etc would be very much appreciated.
Thanks all folks, hopefully we'll get it sorted out quickly.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this. At the simplest level, you can't make a contribution and then call it "Not a contribution". However, new stuff can be discussed but not contributed as long as you mark it that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marty-johnson59 Could you take a look? I think we're fine but I'm not a lawyer, and have no wish to have an opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll bring this up with Khronos legal, but my read is that this was a "contribution", so not sure we're OK with marking it as "not a contribution"... @fgiancane8, can you help clarify how/why this should not be considered a contribution? That might help our legal team sort this out. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marty-johnson59 hello Marty,
thanks for the feedback. I have just followed the directions from the legal team who is in changer of reviewing patches internally. I will ask to review again if upstream is not OK with changes not being a contributions. We have different policies with respect to licenses so I am following the rules here. Will ping you back once I have more answers. thanks for the patience :)