safe: Use Effective extended flags#371
Closed
spencer-lunarg wants to merge 1 commit intoKhronosGroup:mainfrom
Closed
safe: Use Effective extended flags#371spencer-lunarg wants to merge 1 commit intoKhronosGroup:mainfrom
spencer-lunarg wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
fad089b to
63bff3e
Compare
ziga-lunarg
approved these changes
Apr 7, 2026
63bff3e to
4db7343
Compare
Contributor
Author
|
... so this failed, going decided this isn't the place to do it... Quake 2 level doom as I said |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for future extending flags extensions, I think it would be better to just have the "effective" flag value in safe struct
From validation, I find the ONLY 2 reasons we want the "original" value is
Location(which we can still do checking if pNext has the struct on an error)vkCreateBuffer) but at that point, we have not made a safe struct copy yetThe whole "idea" of safe struct was to make our own internal copy and I can't think (so yell at me with it if you can think) why Safe Struct should not have the effective flag value