Increase input_attachment_index limit#4352
Merged
Merged
Conversation
The new limit is INT_MAX, as opposed to UINT_MAX, because INT_MAX is large enough and there are other places in the code where the value of the limit is cast to int.
|
|
arcady-lunarg
approved these changes
Jul 23, 2026
Contributor
|
Apparently there's supposed to be a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new limit is INT_MAX, as opposed to UINT_MAX, because INT_MAX is large enough and there are other places in the code where the value of the limit is cast to int.
The need to increase this comes from an upcoming Vulkan extension that will allow the indices to be much larger in practice, and I'm creating GLSL tests in CTS. I would very much like not to have to write SPIR-V assembly for this.