Reorganize tests a bit#130
Merged
Merged
Conversation
Both tests previously used 13 video+subtitle pairs. The batch behavior is adequately tested with 3 files, cutting ffmpeg overhead significantly. Remove unused default_video_set and get_default_media_set_regex.
Exercises the full CLI path: UtilitiesTool.setup_parser → analyze → perform. Verifies that scene directories are created and output format is respected.
Two CLI tests exercise the full MeltTool.setup_parser → analyze → perform path: a simple same-length duplicate merge and a dry-run verification.
The old test only verified that mkvextract cannot extract WebVTT tracks. The new test runs language_fix via CLI on a video with WebVTT subtitles and verifies the tool handles the unextractable tracks without crashing.
Test CD-pattern regex matching, case insensitivity, separators (space, hyphen, dot), directory-based patterns, sequence validation, gap detection, ignore-warnings filtering, rmvb→mkv conversion, and part sorting. All tests mock collect_video_files — no ffmpeg needed.
Test subtitle sorting with priorities, None language handling, and unknown languages. Test directory matcher with simple matches, multiple subtitles per video, unmatched files, and longest-prefix matching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.