Fix broken user popout header rendering#72
Open
valipuha wants to merge 1 commit into
Open
Conversation
Stop hiding the user popout container wrapper that now appears to hold real header content after Discord markup changes. This keeps the promo-related hides in place while allowing the popout header to render again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the user popout header container that the theme was incorrectly hiding.
Root cause
The theme treated
.containerWrapper_b1818fas part of the Nitro banner promo UI and forced it todisplay: none. After Discord’s markup changes, that wrapper appears to contain real user popout header content, which left the popout header partially blank/broken.Changes
.containerWrapper_b1818ffrom the “Hide Nitro Banner AD” selector listValidation
DiscordNight.cssgit diff --checksuccessfullyNotes
This repository does not include automated UI tests, so final confirmation should be done in the Discord desktop app.