Skip to content

chore(deps): update protobufjs to v8#3042

Merged
chrarnoldus merged 2 commits intomainfrom
chore/update-protobufjs-v8
May 5, 2026
Merged

chore(deps): update protobufjs to v8#3042
chrarnoldus merged 2 commits intomainfrom
chore/update-protobufjs-v8

Conversation

@kilo-code-bot
Copy link
Copy Markdown
Contributor

@kilo-code-bot kilo-code-bot Bot commented May 5, 2026

Summary

  • Bumps protobufjs from 7.5.4 to ^8.0.3 via a pnpm.overrides entry in the root package.json.
  • protobufjs is not a direct dependency of any package in this repo; it is only pulled in transitively by @opentelemetry/otlp-transformer, which uses it to encode/decode OTLP protobuf payloads against its own pre-generated descriptors.

Why the v8 breaking change does not impact us

The only breaking change in protobufjs v8.0.0 is the addition of Edition 2024 support in the .proto parser. That affects code paths where .proto files are parsed at runtime (or via pbjs/pbts) to build Root/Type descriptors.

We do not do that anywhere:

  • No package in this repo declares a direct dependency on protobufjs.
  • No .proto files are shipped or loaded at runtime.
  • The sole consumer, @opentelemetry/otlp-transformer, uses bundled, statically generated OTLP descriptors and only uses protobufjs for wire-format encode/decode, which is unchanged by the Edition 2024 work.

In addition to the edition work, v8 rolls up the 7.5.5 / 7.5.6 input-hardening and security fixes, so this is a safe upgrade for our usage.

Verification

  • grep -rn protobufjs across package.json files confirms no direct dependents; the only reference is the pnpm.onlyBuiltDependencies allowlist entry (build-script approval, not a dep).
  • pnpm-lock.yaml shows protobufjs@7.5.4 only under @opentelemetry/otlp-transformer.
  • Lockfile regeneration (pnpm install) intentionally skipped in this commit per the request; will be applied together with CI/typecheck in a follow-up run before merge.

Visual Changes

N/A

Reviewer Notes

  • The override uses ^8.0.3 so we pick up 8.x patch releases automatically.
  • pnpm install still needs to be run to regenerate the lockfile before this can land — flagging so reviewers are not surprised by the missing lockfile update.
  • If any future service starts parsing .proto files at runtime, that code should be reviewed against the Edition 2024 parser changes, but nothing today does.

@kilo-code-bot
Copy link
Copy Markdown
Contributor Author

kilo-code-bot Bot commented May 5, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • package.json
  • pnpm-lock.yaml

Reviewed by gpt-5.5-20260423 · 136,201 tokens

@chrarnoldus chrarnoldus merged commit 62e195a into main May 5, 2026
40 checks passed
@chrarnoldus chrarnoldus deleted the chore/update-protobufjs-v8 branch May 5, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants