fix(vscode): keep scroll-to-bottom button above sticky accordion headers#9058
Closed
Githubguy132010 wants to merge 1 commit intoKilo-Org:mainfrom
Closed
fix(vscode): keep scroll-to-bottom button above sticky accordion headers#9058Githubguy132010 wants to merge 1 commit intoKilo-Org:mainfrom
Githubguy132010 wants to merge 1 commit intoKilo-Org:mainfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by gpt-5.4-20260305 · 348,704 tokens |
Collaborator
|
@Githubguy132010 would you be so kind and add some screenshots for UI changes? It's quite hard to review so many PR's and screenshots really help to understand what changed in the UI. Thanks |
Contributor
Author
I'll do that later. Expect changes later today. |
The floating scroll-to-bottom button paints correctly over normal content (bash/terminal output, plain text) but gets hidden by Edit/Write/apply_patch tool cards. The reason isn't layout — it's a z-index bug: sticky-accordion-header.css gives the accordion header z-index: 10 so it sticks properly when scrolling, but the button had no z-index, so the sticky header wins the stacking order and paints over it. Bash output has no sticky header, which is why terminal overlap looks right. Bump .scroll-to-bottom-button to z-index: 20 so it sits above the sticky header. No layout shift, no repositioning — the button just stops being painted over by content that was always meant to pass under it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
50e984f to
04a9688
Compare
Contributor
Author
|
Can't repro on main anymore. Likely already fixed. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Follow-up to #9056 (review discussion about the scroll-to-bottom button appearing "overlapped" by a Write tool's accordion chevron).
Turned out not to be a layout problem at all — it's a z-index bug. The floating
.scroll-to-bottom-buttonpaints correctly over normal content (bash/terminal output, plain text), but Edit/Write/apply_patch tool cards paint over it. The reason:sticky-accordion-header.csssetsz-index: 10on[data-component="sticky-accordion-header"]so the accordion header sticks cleanly when scrolling past, and the button had noz-index, so the sticky header wins the stacking order. Bash output has no sticky header, which is why terminal overlap has always looked right — the button sits on top, content flows under it.Implementation
One-rule fix in
chat-layout.css:No layout shift, no repositioning, no reflow. The button now wins the stacking order against every tool card, so it behaves uniformly whether the scroll-past content is bash output, a text message, or an Edit/Write/apply_patch accordion.
Screenshots
How to Test
Created/+N -Mbadge — same as it already does over bash output.Get in Touch
🤖 Generated with Claude Code