[pull] master from getsentry:master#1831
Merged
Merged
Conversation
Wraps non-compliant routes in the alerts area with Layout.Page. Part of the Layout.Page audit remediation. ## Changes - `static/app/views/alerts/list/incidents/index.tsx` — wrap `renderBody()` return and `renderDisabled()` in `Layout.Page` - `static/app/views/alerts/list/rules/alertRulesList.tsx` — wrap `PageFiltersContainer` block in `Layout.Page` - `static/app/views/alerts/create.tsx` — replace outer `Fragment` with `Layout.Page` - `static/app/views/alerts/edit.tsx` — replace outer `Fragment` with `Layout.Page` ## Affected routes | Path | Strategy | | --- | --- | | `/organizations/:orgId/alerts/` | leaf fix | | `/organizations/:orgId/alerts/rules/` | leaf fix | | `/organizations/:orgId/alerts/:projectId/new/` | leaf fix | | `/organizations/:orgId/alerts/crons-rules/:projectId/:monitorSlug/` | leaf fix | ## Verification - [x] Each route above loads in the browser and renders inside a `<main>` element --------- Co-authored-by: Priscila Oliveira <priscila.oliveira@sentry.io> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Wraps non-compliant routes in isolated page areas with Layout.Page. Part of the Layout.Page audit remediation. ## Changes - `static/app/views/insights/pages/conversations/layout.tsx`: moved `Layout.Page` from `overview.tsx` to the layout component so it wraps both the header and outlet content - `static/app/views/insights/pages/conversations/overview.tsx`: removed `Layout.Page` (now handled by layout) - `static/app/views/profiling/continuousProfileProvider.tsx`: added `Layout.Page` wrapping header + outlet so flamegraph pages get correct framing - `static/app/views/profiling/transactionProfileProvider.tsx`: added `Layout.Page` wrapping header + outlet so flamechart pages get correct framing - `static/app/views/profiling/continuousProfileFlamegraph.tsx`: removed `Layout.Page` (now handled by provider) - `static/app/views/profiling/profileFlamechart.tsx`: removed `Layout.Page` (now handled by provider) - `static/app/views/profiling/profileSummary/index.tsx`: wrap `ProfileSummaryPageToggle` with `Layout.Page` - `static/app/views/profiling/differentialFlamegraph.tsx`: wrap `DifferentialFlamegraphWithProviders` with `Layout.Page` - `static/app/views/projectInstall/newProject.tsx`: wrap `NewProject` content with `Layout.Page` ## Affected routes | Path | Strategy | | --- | --- | | `/organizations/:orgId/explore/conversations/` | layout-level wrap (header + outlet) | | `/organizations/:orgId/profiling/profile/:projectId/flamegraph/` | provider-level wrap (header + outlet) | | `/organizations/:orgId/profiling/profile/:projectId/:eventId/flamegraph/` | provider-level wrap (header + outlet) | | `/organizations/:orgId/profiling/summary/:projectId/` | leaf fix | | `/organizations/:orgId/profiling/profile/:projectId/differential-flamegraph/` | leaf fix | | `/organizations/:orgId/projects/new/` | leaf fix | ## Verification - [ ] Each route above loads in the browser and renders inside a `<main>` element --------- Co-authored-by: Priscila Oliveira <priscila.oliveira@sentry.io> Co-authored-by: Claude Opus 4.6 <noreply@example.com>
This reverts commit 347562e. Co-authored-by: priscilawebdev <29228205+priscilawebdev@users.noreply.github.com>
Protocol definitions are expected to be imported by the end-user. They should be in a public module. `types.py` makes the most sense.
Change publish_status from PRIVATE to PUBLIC on the replay deletion job endpoints (index and detail) and add @extend_schema decorators with operation IDs, response types, and OpenAPI examples so that drf-spectacular generates documentation for them. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ds (#111534) When duplicating a prebuilt dashboard, the clone was reconstructed from static config which has empty default values for page-level filters. The previous fix (#111017) copied the `DashboardFilters` object (`globalFilter`, `release`) but missed the top-level page filter fields (`projects`, `environment`, `period`, `start`, `end`, `utc`). This also fixes the manage/list view duplication path (`useDuplicateDashboard`) which never fetched the saved dashboard instance at all for prebuilt dashboards, so all saved filters (including `globalFilter`) were lost in that code path. Both paths now use a shared `copySavedFilters` helper that copies all 7 filter fields from the saved instance onto the clone. Refs DAIN-1406 Co-authored-by: Claude <noreply@anthropic.com>
region is being deprecated from this decorator, switch to the new parameter `cells`
…111709) Hide Sentry Built dashboards from the All Dashboards list by adding the `excludePrebuilt` filter to the dashboard list API call. Previously the All Dashboards view showed all dashboards including prebuilt ones, which was surfaced as feedback from both internal and external users. Prebuilt dashboards remain discoverable via the Sentry Built tab. Refs LINEAR-DAIN-1415 Co-authored-by: Claude Opus 4.6 <noreply@example.com>
…#111597) flips the wire format from "region_name" to "cell_name". Alias is still present for deploy safety.
errors on EAP calls for new UI obv. This the feature flag for it
…DetailsRoute (#110122) Part of the React Router 6 cleanup — replaces `useRouter()` with specific hooks (`useNavigate`, `useLocation`, `useParams`, etc.) --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
…shboards Generate (#111712) - updates badge from experimental to beta - checks for areAiFeaturesAllowed
…ionsWidget (#110126) Part of the React Router 6 cleanup — replaces `useRouter()` with specific hooks (`useNavigate`, `useLocation`, `useParams`, etc.)
github-actions
Bot
added
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )