[pull] master from getsentry:master#1833
Merged
Merged
Conversation
Add a flag to release the rule stats and group history workflow engine versions of the endpoints. These complement the `ProjectRuleDetailsEndpoint` which is [about to be released to GA](getsentry/sentry-options-automator#7008) as they provide additional context for rendering the page.
To prep for #111760 this PR moves a bunch of functions into a utils file from a file that will soon be deleted.
… combined-rules serializer (#111743) The WorkflowEngineDataConditionSerializer assumed all DataCondition comparison values in workflow DCGs were numeric, which holds for dual-written rules but not for single-written rules where anomaly detection conditions can store dict comparisons. Filter to numeric values only when building the comparison lookup. Fixes SENTRY-5MHW.
…wEngineActionSerializer (#111763) Avoids a query per action, and makes further refactors to improve batching more effective.
# Description When investigating an issue, it was difficult to determine the source of the issue because we hit the exception block and lost which of the ValidationError was bubbling up. This will just allow the more specific validation error to bubble up and reformat them to all be ValidationErrors that can be handled in the API. The code still catches the exception and retriggers it to ensure the control flow is consistent and the validation error types are correct.
github-actions
Bot
added
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )