[pull] master from getsentry:master#1838
Merged
Merged
Conversation
- The API response cannot be relied upon to be correctly sorted currently - Quick frontend fix is to sort on the frontend Closes TET-2150
…tegrations (#110324) When stack trace frames lack inline source context, this feature fetches the file from the configured SCM integration (GitHub, GitLab, Perforce) and returns the surrounding lines via a new API endpoint. - New endpoint: /projects/{org}/{project}/stacktrace-source-context/ - New utility: fetch_source_context_from_scm() with caching - Feature-flagged behind organizations:scm-source-context --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
This changes the `apigateway` proxy to be async, with the idea to serve the relevant deployment of control silo in ASGI rather than WSGI. The rationale here is to avoid situations in which we exhaust the server's threadpool by just waiting for apigateway requests to complete, as we saw in INCs 2054/2056. **Note:** the APIGateway changes are gated into a separated Python module, the async flow is enabled through `SENTRY_ASYNC_APIGW` environment variable. This allows us to control the rollout of the change in prod. Tests and local devserver are instead always using the new code. Detailed changes: - [x] Make APIGateway proxy `async`, switching inner client impl from `requests` to `httpx` - [x] Change APIGateway middleware to work both in ASGI and WSGI contexts (with the latter using `async_to_sync`) - [x] Update relevant tests interacting with APIGateway - [x] Fix proxy acceptance test - <s> Fix ORM calls in the custom SDK integration</s> - [x] Bypass ORM calls in SDK custom logging integration - [x] Restore/adapt circuit brakers
github-actions
Bot
added
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )