[pull] master from getsentry:master#1848
Merged
Merged
Conversation
Some notification settings were not updating the underlying data on success, leading to the form being reset with stale `initialData`. In effect, the form appeared to not trigger any update from the frontend—a hard refresh would display the correct values because the backend did process the update. Closes DE-1043, closes #112143 --------- Co-authored-by: Dominik Dorfmeister 🔮 <dominik.dorfmeister@sentry.io>
This reverts commit `787bdf4`, which reverted #111369 due to an unintentional change to the internal DOM structure of Button. adds an indeterminate loader to our design system and hooks it up to our button ## [`IndeterminateLoader`](https://sentry-git-scraps-loader-ii.sentry.dev/stories/core/loader/) https://github.com/user-attachments/assets/312c1d5a-f4ef-4d80-9844-611529502a1d ## [`<Button busy>`](https://sentry-git-scraps-loader-ii.sentry.dev/stories/core/button/#busy-buttons) https://github.com/user-attachments/assets/29b8c3b6-c1f9-4dc1-95df-bc439df99a96
Previously, `groupingInfoSection.spec.tsx` was testing the `GroupingInfoSection` component: but all that component does is combine the `InterimSection` component with a lazy-loaded `GroupingInfo` component. That lazy-loading can take >=100-150ms locally, and might be the cause of flake in CI. This PR changes the test to: * Directly test `GroupingInfo`, bypassing the lazy-load * Delete the specific flaky test that was checking for the component being loaded after click (since that's covered by `FoldSection`'s unit tests, as rendered by `InterimSection`) Fixes ENG-7209 ~Note that CI Jest tests are failing because the https://github.com/getsentry/sentry/labels/Frontend%3A%20Rerun%20Flaky%20Tests label is causing _other_, still-flaky tests to be run.~ Rebased on `master` so the `it.isKnownFlake` (#111860) addition isn't here yet. Made with [Cursor](https://cursor.com) Co-authored-by: @nikkikapadia
Previously, the `StatusIndicator` component was rendered with the pulse on top of the dot. By splitting into separate `::before` and `::after` elements, the layering is fixed. **Before** (subtle, but accent variant is dimmed) <img width="351" height="472" alt="before" src="https://github.com/user-attachments/assets/37d5d522-b90e-4527-8d83-3952e94853c2" /> **After** <img width="411" height="553" alt="after" src="https://github.com/user-attachments/assets/f96509d1-ed06-4cf7-a8a8-298d933e9a91" />
github-actions
Bot
added
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )