[pull] master from getsentry:master#1992
Merged
Merged
Conversation
This is no longer in use so time to remove it.
- When the flag is enabled, sets enable_frontend_code_search: true in seer chat request - The frontend code search needs to know the feature flags enabled for an org - so this PR adds a get_organization_features RPC endpoint that returns all active api_expose=True flags. Seer can call this on demand to validate what features are enabled in the user's Sentry frontend --------- Co-authored-by: Claude Sonnet 4 <noreply@anthropic.com>
…116101) Generated with claude ## Summary - The tracemetrics aggregate signature is `func(attribute, metric_name, metric_type, metric_unit)` — all four positional arguments are required (see `src/sentry/search/eap/trace_metrics/aggregates.py` and the validator in `src/sentry/search/eap/columns.py:776-795`). - The previous AI dashboard guidance only mentioned three arguments, so the agent emitted widgets like `avg(value, dashboards.widget_query_queue.time_to_empty, distribution)` and hit `Invalid parameter dashboards.widget_query_queue.time_to_empty. Must be one of ['', 'counter', 'gauge', 'distribution']`. - Why it fails: the resolver (`src/sentry/search/eap/resolver.py:1181-1188`) fills missing args from the front when defaults are available. With 3 args supplied, the empty default lands in the metric_name slot and the real metric_name shifts into the metric_type slot, tripping the literal validator. - Update both the on-page guidance (`TRACE_METRICS_GUIDANCE`) and the artifact schema field description (`GeneratedWidgetQuery.aggregates`) to spell out the 4-argument shape, require the agent to look up `metric_type` AND `metric_unit`, and document `-` as a fallback when only the unit is unknown. --------- Co-authored-by: Claude <noreply@anthropic.com>
When a customer goes to explore/<random-path>, the user sees a “The project you were looking for was not found.” error, which is a wrong behavior and error to show. This is because it tries to match an explore/* path, which isn't defined, and eventually matches the **legacyOrgRedirects** route, treating both params as :orgId/:projectId. This ticket adds a splat (*) path to the explore path and redirects users to the index explore component. Fixes EXP-959
I've added a `View related traces` link in the tooltip so that users can use heat maps to dig in to problem areas or general trends. The link should direct them to the traces page with the correct cross-event and page filters populated. Couple things to note here: 1. I think we're using a logarithmic y-axis scale so i might have to fix some of the link data 2. the tooltip renderer for e-charts does not accept react components (which is why i've done the hacks that i've done) Closes DAIN-1641 | Before | After | |--------|--------| | <img width="376" height="173" alt="image" src="https://github.com/user-attachments/assets/38e330c3-d894-4858-a833-d6c238acd242" /> | <img width="356" height="213" alt="image" src="https://github.com/user-attachments/assets/cfd475e3-c00c-4201-9082-0b11007a0e90" /> |
github-actions
Bot
added
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )