[pull] master from getsentry:master#1995
Merged
Merged
Conversation
…gger (#116104) Fix editor dropdown placement, so the apply button is visible Before <img width="424" height="393" alt="image" src="https://github.com/user-attachments/assets/36cb7f3a-aac3-45eb-91d5-8ea623d61a54" /> After <img width="424" height="393" alt="image" src="https://github.com/user-attachments/assets/a92f0e97-a62b-41e4-bd0f-d54f57671453" /> Fixes DAIN-1677
) Stop click events from bubbling out of widget header action buttons (full-screen view, copy URL). On prebuilt dashboards like Web Vitals that wire a slideout drawer to the wrapper's `onClick`, the bubble caused the full-screen modal and the slideout drawer to open from a single click and overlap. **Root cause** The header buttons in `widgetFrame.tsx` didn't `e.stopPropagation()`, so a click on the expand icon fired the button's `onFullScreenViewClick` *and* bubbled up to `GridWidgetWrapper`'s `onClick` in `sortableWidget.tsx`, which opens the slideout. Same bubble exists for the Copy URL button and any single custom action. **Fix** Each header action button now stops propagation before invoking its handler. The wrapper's click target stays the widget body, so the slideout only opens when the user actually clicks into the widget body — not when they interact with a header button. Fixes DAIN-1684
The goal of this PR is to tweak the styles for the cross-event query section based off of the period selection. There are a couple issues currently when selecting an exact date range so this PR tweaks the styles based off of that condition.
…ays (#116099) For cross event queries in explore we only limit the user to making 7 day queries at a time. The only issue was we needed to have the ability to query a 7 day range within the `maxPickableDays` (of 90 days in this case) but there's no way to do that right now since `maxPickableDays` doesn't respect `maxDateRange`. Ideally if there's a `maxDateRange` the default time periods shown will be within that date range instead of just relying on `maxPickableDays`. I've only made changes to the logic if BOTH `maxPickableDays` and `maxDateRange` are passed in. I took a look to see if there are any other parts of the app that use `maxDateRange` and i don't see any references to it so this shouldn't cause odd behaviour on any other date selector :) Here's what it's looking like: https://github.com/user-attachments/assets/eedea627-5955-4c16-addf-f31c1cc0e4f2
…6105) propogate global filters in open in issues link For example: 1. If i have a transaction filter on the issues dataset <img width="854" height="411" alt="image" src="https://github.com/user-attachments/assets/9f58c282-53be-4ca5-a597-db3aa8f05795" /> 2. Clicking `open in issues` actually populates the query now <img width="1177" height="191" alt="image" src="https://github.com/user-attachments/assets/af79cc4c-7471-4ab3-b5df-0c58089f6bb0" />
github-actions
Bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )