[pull] master from getsentry:master#1996
Merged
Merged
Conversation
…15805) Adds "Open in Explore" for metrics dashboard equation widgets. We only support a single equation in metrics widgets. Because of the type of widget queries and aggregates we need to loop over them, but there will only be one widget queries while the single equation condition holds. If the aggregate is an equation, it's parsed out into its subcomponents and the query that's saved on the `widgetQueries` is set on that equation.
…es (#116047) The RPC endpoint for tracemetrics doesn't take `equation[0]` as a valid sort and expects the full `equation|...` format. This PR ensures that when we make requests to the datasets with sorts (e.g. grouped series, or categorical bar charts) that the full equation is used. This is done by updating two surfaces: - Updating the series query params to treat `DiscoverDatasets.TRACEMETRICS` similar to spans and logs, which use RPC and have the same constraints/handling - Update the table request for categorical bar charts to detect if the sort is an equation alias, then get the index, get the equations, and use the right equation index to set the sort - Remove equation handling for the widget builder table sort because all datasets that support equations now support the full equation format. It's only the case that some datasets (RPC datasets) don't support the alias format This shouldn't require feature-flagging because it's gated on having the equation builder, which itself is feature flagged. I did a bunch of this PR manually and guided with claude before I realized there was a lot simpler of an implementation where we can internally use the `equation[0]` syntax for now and convert on the requests. At that point I prompted it to remove a bunch of the old cruft, rework the stuff that remained, and add tests.
Rejects widget create/update requests whose `(widget_type, display_type)` combination isn't allowed by the frontend Widget Builder's type selector (e.g. `table` on `tracemetrics`, `table` on `preprod-app-size`). Allowed combinations live in a new `DATASET_CONFIG` map keyed by `widget_type`. Adding the dataset configs also sets us up nicely for more per dataset validation For example, in the ui trace metrics don't support tables, so we shouldn't let them be saved as tables
…zation (#116129) Couple of things to note here. For heat maps we want to default to the largest interval because it shows the most patterns and then users can adjust how they'd like. There wasn't an option to use the largest interval so i added it in. I've also added tests for the `useChartInterval` hook. Test by changing the chart type in metrics to heat map and see the default interval change 🤩
## Summary - Removes the `organizations:data-browsing-widget-unfurl` and `organizations:dashboards-widget-unfurl` registrations from `src/sentry/features/temporary.py`. - Switches the Slack unfurl flag gates over to the base feature flags for each product (`organizations:visibility-explore-view` for explore, `organizations:dashboards-basic` for dashboards) in `explore.py`, `dashboards.py`, and `webhooks/event.py`. This keeps the existing "only unfurl when the org has the underlying product" guard while removing the unfurl-specific flags.
Fix TypeErrors related to UUID not being compatible with msgpack. Fixes SENTRY-5PTW
Fixes DAIN-1690 ## Problem Widget context menus (triggered by clicking the '...' buttons on dashboard widgets) were appearing behind the dashboard navigation sidebar because `theme.zIndex.dropdown` (1001) was lower than `theme.zIndex.sidebarPanel` (1019). Before <img width="297" alt="Screenshot 2026-05-25 at 1 06 18 PM" src="https://github.com/user-attachments/assets/814181dd-572a-4f2d-9679-3bdb57ed101d" /> After <img width="297" height="280" alt="Monosnap General Template copy 35 — sentry — Sentry 2026-05-25 13-53-18" src="https://github.com/user-attachments/assets/119b3eb7-3681-4aec-8e95-7063ea4d6641" /> ## Solution Updated `theme.zIndex.dropdown` from 1001 to 1020 (sidebarPanel + 1) in the theme definition. This ensures all dropdown menus across the application appear above the sidebar panel. Linear Issue: [DAIN-1690](https://linear.app/getsentry/issue/DAIN-1690/menu-appears-behind-dashboard-widget-actions) Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This enables the Add to Dashboard actions for equations and includes it in "All Application Metrics". This feature should be feature flagged
…int (#116145) We want to use medium everywhere, no need to expose this as a parameter.
Replace all usages of useAutofixData with useExplorerAutofix
Relocations haven't used outboxes for at least a year, remove this code. Refs INFRENG-318
github-actions
Bot
added
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )