[pull] master from getsentry:master#2002
Merged
Merged
Conversation
…ropdown (#116272) Restore the inline `with <SDK>` layout on the conversations onboarding panel. In #116082 the `<Flex gap="md" align="center" wrap="wrap" paddingBottom="md">` wrapper around `PlatformOptionDropdown` was replaced by a `<Stack gap="md">` that now wraps the dropdown, the introduction, and the guided steps together. `PlatformOptionDropdown` returns a Fragment containing the `"with"` text node and the `OptionControl` dropdown(s) as siblings — so the Stack hoisted them as separate vertical items and the label ended up above the selector. Wrap just the dropdown row in a `<Flex gap="md" align="center" wrap="wrap">` inside the Stack. The Stack's own `gap="md"` already handles spacing to the next row, so the previous `paddingBottom="md"` is no longer needed. Refs GH-116082
…5882) Adds support for the new `browser.web_vital.<vital>.value` attributes to the web vital pre built dashboard queries. This ensures the pre-built dashboard is compatible with streamed v2 web vital spans and attributes. I left the hard-coded `score` attributes as-is, since these seem to be handled correctly already. Reviewers, please let me know if you want to tackle this differently or are already working on it. I mainly oriented myself on #113046 but happy to change anything or close the PR! My naive assumption was that through coalescing we can switch to querying the new attributes and it works for the old ones as well. Tested with projects sending transactions as well as projects sending v2 spans and both still seem to work. <img width="1635" height="1145" alt="image" src="https://github.com/user-attachments/assets/2560f46e-1dfc-4e58-8ece-2e796e107bf0" />
The `webAuthnRegisterData` and `webAuthnAuthenticationData` fields on `ChallengeData` can be undefined when the server doesn't include WebAuthn data in the challenge response. Without guards, `handleEnroll` and `handleSign` crash when trying to decode `undefined`. This adds early-return null checks and updates the types to reflect the actual API shape. Fixes JAVASCRIPT-397K --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Evan Purkhiser <evanpurkhiser@users.noreply.github.com> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
…16275) - Changes necessary due to [a change in relay](getsentry/relay@eca6948) - [Example for failing tests on some PRs](https://github.com/getsentry/sentry/actions/runs/26496465875/job/78025964034?pr=114286) - Snapshots generated using `SENTRY_SNAPSHOTS_WRITEBACK=new pytest tests/symbolicator/` locally with devservices `relay` and `symbolicator` ended up being volatile (unique IDs) - Use approach to exclude the trace context from the snapshot as has been done with the reprocessing context
Sortable header cells in `SimpleTable` now show a visible focus ring when navigated via keyboard. The ring uses an inset `box-shadow` so it isn't clipped by the Panel's `overflow: hidden` and border. before: https://github.com/user-attachments/assets/a0f87102-dee4-4231-ad59-c23cf8121a61 after: https://github.com/user-attachments/assets/62a74372-e18a-4b76-b275-48b119daa23c Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )