[pull] main from microsoft:main#1358
Merged
Merged
Conversation
The CLI runtime is migrating from the vendor-prefixed github.copilot.time_to_first_chunk attribute to the OTel GenAI semconv attribute gen_ai.response.time_to_first_chunk. Both encode TTFT in seconds. The sqlite store's _ttftMs() now reads either name (preferring the new one) so we keep populating ttft_ms before, during, and after the runtime rollout. Adds two unit tests: one for the new attribute alone, one verifying the new attribute wins when both are present. Refs: open-telemetry/semantic-conventions#3607 github/copilot-agent-runtime#6949
* feat: replace host picker context menu with mobile-native bottom sheet on phone layout Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/c0ced124-328e-43c3-a95c-34c56f55a84d Co-authored-by: osortega <48293249+osortega@users.noreply.github.com> * fix: guard bottom sheet dismiss against double-invocation and stop event propagation from sheet Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/c0ced124-328e-43c3-a95c-34c56f55a84d Co-authored-by: osortega <48293249+osortega@users.noreply.github.com> * refactor: extract mobile host picker into MobileHostFilterActionViewItem Move the bottom sheet UI from an inline phone-layout branch in the desktop HostFilterActionViewItem into a proper mobile subclass in browser/parts/mobile/, following the established mobile architecture: - Create MobileHostFilterActionViewItem extending the desktop class, overriding _showMenu() to show a bottom sheet instead of a context menu - Remove IsPhoneLayoutContext branching from the desktop component - Move bottom sheet CSS from hostFilter.css to mobileChatShell.css - Update hostFilter.contribution.ts to instantiate the mobile variant for the MobileTitleBarCenter menu registration - Add Mobile Component Architecture rules to sessions.instructions.md Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: replace bottom sheet with dropdown anchored below trigger The bottom sheet slid up from the bottom of the screen, far from the picker trigger at the top, and had a transparent background. Replace with a dropdown panel that: - Anchors directly below the trigger element - Has a solid background with border and shadow - Animates in/out with a subtle fade + slide from above - Uses 44px min-height items for touch targets - Transparent backdrop for dismiss-on-tap without visual overlay Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: improve mobile host picker dropdown design - Use agentsChatInput background color to match the chat input - Add font-weight: normal to prevent bold text in items - Add Gesture.addTarget + TouchEventType.Tap on each item button so taps register on iOS/touch devices (CLICK alone is unreliable) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * refactor: move host picker dropdown CSS to own component file - Create media/hostPickerDropdown.css in mobile parts folder - Move all host picker styles from mobileChatShell.css to dedicated component file - Add CSS import in mobileHostFilterActionViewItem.ts - Document CSS organization pattern in sessions.instructions.md This follows the same pattern as regular VS Code parts where each component owns its CSS in a media/ subfolder. Keeps mobileChatShell.css focused on shell-level phone layout styles only. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: use defined CSS theme variables for host picker dropdown Replace undefined fallback variables with proper agentsChatInput theme tokens: - background: var(--vscode-agentsChatInput-background) - foreground: var(--vscode-agentsChatInput-foreground) - border: var(--vscode-agentsChatInput-border) These variables are registered in src/vs/sessions/common/theme.ts and properly available in all themes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: use globally available CSS theme variables for host picker Replace agentsChatInput variables (only available in .agent-sessions-workbench scope) with globally available input and foreground variables since the backdrop is rendered directly on body, outside the workbench scope. - background: var(--vscode-input-background) - foreground: var(--vscode-foreground) - border: var(--vscode-input-border) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: use inline styles from theme service for host picker CSS variables aren't available in the body scope where the dropdown is rendered. Instead, fetch theme colors via IThemeService and apply them as inline styles: - Get theme colors at dropdown creation time - Set backgroundColor, borderColor, foregroundColor via style attribute - Apply hoverBackgroundColor and linkColor via event listeners - Remove all CSS variable references This ensures colors work in vscode.dev and all environments where CSS variables may not be injected. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: remove unused focusBorderColor variable The focus border styling is handled by the CSS :focus-visible rule, so the TypeScript variable is not needed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: render dropdown inside workbench container for CSS variables The dropdown was appended to document.body, which is outside the .monaco-workbench element where --vscode-* CSS custom properties are defined. This caused all theme variables to be undefined. Fix: query for the .monaco-workbench container and append the backdrop there instead. This restores CSS variable inheritance and moves all color declarations back to the CSS file where they belong. Also reverts the IThemeService inline-styles approach — colors are now purely in hostPickerDropdown.css using standard CSS variables. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: center host picker dropdown and remove status text 1. Center the dropdown horizontally on screen using left: 50% + translateX(-50%) instead of anchoring to the trigger's left edge. 2. Remove the 'connecting…' / 'disconnected' status text from dropdown items — the titlebar connection icon already conveys this info, and the status text was causing the dropdown to extend beyond screen. 3. Clean up unused AgentHostFilterConnectionStatus import and status CSS. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: include translateX(-50%) in dropdown animation keyframes The entrance/exit animations were overriding the centering transform during playback, causing the dropdown to appear right-aligned then jump to center when the animation ended. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: remove stray closing brace in mobileChatShell.css Leftover from extracting host picker CSS into its own file. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: address PR review comments 1. Fix dismiss race condition: guard the timeout callback so it only clears the dropdown if it still owns the current store, and register the timeout for disposal when the dropdown is reopened early. 2. Use correct ARIA pattern: switch from listbox/option to menu/menuitemradio which better matches the single-select interaction pattern. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
otel: support gen_ai.response.time_to_first_chunk in sqlite store
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: vs-code-engineering[bot] <vs-code-engineering[bot]@users.noreply.github.com>
* enable progress border in insiders + reduce motion * some cleanup * address comments
…2954) Co-authored-by: vs-code-engineering[bot] <vs-code-engineering[bot]@users.noreply.github.com>
* Clean up some parameters and stuff in Claude Just some debt. * fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )