[pull] main from microsoft:main#1394
Merged
Merged
Conversation
After bumping xterm.js to beta.213 (#313817), three error buckets keep firing the same Cannot read properties of undefined (reading 'dimensions') TypeError on the latest insider builds (1.120.0-insider 79d6cea / 0aed0a9): - aaa283a2 - resize -> _resizeYCallback -> _updatePtyDimensions, triggered by config-change -> setVisible -> _resize. - 4826565b - debounced _debounceResizeX timer firing after the renderer is gone. - 1e83a096 - _onProcessExit -> dispose -> setVisible(false) -> _resize -> _resizeBothCallback. All three reach RenderService.get dimensions() in xterm.js, which dereferences this._renderer.value (undefined post-dispose) and throws synchronously. The optional chaining on rawXterm.dimensions doesn't help because the getter itself throws. The upstream beta.213 fix added isDisposed guards at the OverviewRuler call sites, not inside the getter, so the correct symmetrical fix here is to guard the call sites that VS Code owns: * terminalInstance.ts: bail out of the resize closures and _updatePtyDimensions when the instance is already disposed; defensively wrap the dimensions read in try/catch so a future renderer-dispose race fails silently instead of bubbling as an unhandled error. * terminalResizeDebouncer.ts: bail out of resize/flush and the runWhenWindowIdle / @debounce-scheduled callbacks when the debouncer's store is disposed - the @debounce decorator schedules a setTimeout that isn't tied to the disposable store. Refs #303546, #313817
Esbuild's watcher (maybe go's?) is having continual 2-5% cpu usage even when nothing is happening. With 15 extensions, this is causing too much load compared to parcel
…ile another is active (#314913) sessions: fix duplicate session in list when new session opened while another is active When a new CLI session was created and the user opened another session before the new one fully graduated: 1. SessionAdded notification from the agent host arrived before _pendingSession was set, so _sessionCache already contained the committed session when the skeleton was added as _pendingSession. getSessions() then returned both, causing the duplicate row. 2. SessionsManagementService.onDidReplaceSession only fired _onDidChangeSessions when the active session was the 'from' session. If the user had navigated away, no refresh event fired and the SessionsList kept showing the duplicate indefinitely. Fix: - Clear _pendingSession before firing _onDidReplaceSession so any synchronous listener that calls getSessions() sees only the committed session (the finally block still clears it on the failure path). - Always fire _onDidChangeSessions in onDidReplaceSession; only the active-session reassignment remains conditional. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Switch back to using parcel's watcher for esbuild
Pick up latest TS native preview for building VS Code
Move test file to correct layer to fix build break
This adds a propose api for computing the diff between two files. Custom diff editors can use this to make sure they have the same diffs that VS Code would use in it's built-in diff editor
…314920) in autopilto and bypass we should never show global auto dialogue
Enable extensions in sessions window
* refactor: remove sub application support * chore: remove OS entries * chore: update additional shortcut location on windows * chore: show one time deprecation banner * remove other indirect instances of embedded app --------- Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com>
…-buttons Disable unified quick access when AI features are disabled
Add document diff api proposal
…-dispose-race Guard terminal resize/dispose race against xterm.js dimension getters
feat: add Get Changed Files tool configuration and enablement in Copi…
…e-angelfish Add selected foreground and icon foreground colors for editor suggest widget
style: enhance shimmer effect for in-progress session titles with support checks Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com>
BYOK: Add provideId static property to all providers
…me (#314960) feat: add borders for agents new session button and chat input in light theme Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com>
…agnostics BYOK: Avoid auth token retrieval for diagnostics purposes only
…d by vscode (#306955) allow return readonly T[] for TreeDataProvider.getChildren Co-authored-by: Alex Ross <38270282+alexr00@users.noreply.github.com>
* fix: disable auto model feature in CLI configuration * fix: update tests to explicitly enable CLIAutoModelEnabled after default changed to false Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/4384e16e-ab3e-4ad5-aa27-6e4d4439ed89 Co-authored-by: DonJayamanne <1948812+DonJayamanne@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
fix: reduce gap between radio buttons in tabbed action list Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
…nd menu components
Disable unsupported built-in extensions in sessions window
* Add detailItemHeight option for action list and adjust styles * Adjust padding for action list row elements * Add detailItemHeight option to permission picker action item list options --------- Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )