[pull] main from microsoft:main#1417
Merged
Merged
Conversation
…rness (#316144) * sessions: hide harness picker and host suffix in web when single harness In vscode.dev/agents the workbench is already scoped to a single agent host via the host filter, so: 1. The session-type picker in the new chat view is hidden when there is only one harness available (nothing to pick). The existing CSS rule on `.session-workspace-picker-with-label` collapses the dangling "with" connector automatically via `:has()`. 2. The `[Host]` suffix is dropped from session-type labels, so they read e.g. "Copilot CLI" instead of "Copilot CLI [My Host]". Both behaviors are gated on `isWeb` / `isWebPlatform`; desktop is unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * sessions: update tests for web no-host-suffix label Browser tests run with isWebPlatform === true by default, so the existing assertions for 'Copilot [My Host]' need to drop the suffix. Add an explicit desktop-branch test that overrides isWebPlatform to preserve coverage for the suffixed label. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * sessions: keep desktop test assertions, add explicit web coverage The browser test runner runs in electron renderer where isWeb is false, so the existing 'Copilot [My Host]' assertions were correct. Restore them and add a separate test that overrides isWebPlatform: true to cover the web no-suffix branch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * sessions: pin host-suffix tests to desktop branch Tests run in both electron renderer (isWeb=false) and playwright browser (isWeb=true), so assertions that depend on the platform branch must override isWebPlatform explicitly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fix desktop config picker order on mobile-aware subclass The session-config picker action view item always instantiates MobileAgentHostSessionConfigPicker (so its _showPicker can route to the mobile bottom sheet on phones). _showPicker correctly delegates to super on desktop via an isPhoneLayout guard, but _orderProperties was missing the same guard, so desktop viewports were rendered with the mobile chip-lane order (Branch, Worktree) instead of the desktop order (Worktree, Branch). Add the same isPhoneLayout guard to _orderProperties so desktop viewports defer to the base ordering. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…t display (#316149) * refactor: disable fetching agents from SDK due to performance concerns * fix: defer marking old chat model as read to prevent blocking new chat display * revert for now * fix: register deferred old-session read timer with disposables Co-authored-by: DonJayamanne <1948812+DonJayamanne@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
* Optimize agent mode instructions handling for efficiency * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ly (#316153) * Refactor getSDKAgents to avoid using SDK for finding agents temporarily * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Updates * Refactor getAgentsImpl to remove SDK agent retrieval for improved performance --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* send telemetry for CLI tool calls * 💄 * Address Copilot CLI telemetry review feedback * Fix Copilot CLI telemetry tool name fallback
…#315558) * build: bump @vscode/gulp-electron to 1.41.3 Brings in microsoft/vscode-gulp-electron#42 which adds retry-with-backoff around transient network errors when downloading Electron, fixing build breaks like getaddrinfo ENOTFOUND release-assets.githubusercontent.com. NOTE: package-lock.json will be regenerated once 1.41.3 is published. Do not merge until then. * Sync package-lock.json with package.json after updating @vscode/gulp-electron to 1.41.3.
…les (#316173) After Windows smoke tests finish, Electron child processes (ptyHost, sharedProcess, network-shared, etc.) can outlive the main process and keep .build/logs/smoke-tests-electron/*/main.log and friends locked. That makes the 1ES auto-injected 'Publish Log Files' output fail when it tries to hash those files (~2 minutes later), failing the whole Windows Electron Tests job even though all tests passed. Add a defensive cleanup step right after PublishTestResults that force-kills any process whose executable lives under the test build directory, so the publish step has unlocked files to hash. Refs flaky-test occurrence in build 438755 attempt #1.
…eriment (#316178) Re-introduces `cache_control.ttl: "1h"` for the Anthropic Messages API tools + system breakpoints, gated on the main agent conversation where the 2x cache-write cost trades favourably against the longer hit window. Previously reverted from the copilot-chat repo. All four gates must hold: - Model is a 1M-context Claude variant (`claude-opus-4-{6,7}-1m...`) - Setting `github.copilot.chat.anthropic.promptCaching.extendedTtl` is on (ConfigType.ExperimentBased, default false, advanced/experimental/onExp) - Location is `ChatLocation.Agent` (Panel/Editor/Terminal/Notebook/ EditingSession/Other and both proxy locations are excluded) - Request is not a subagent (typed via `interactionTypeOverride === 'conversation-subagent'`, the same source of truth as the `X-Interaction-Type` wire header) When all gates pass: - The `extended-cache-ttl-2025-04-11` beta header is added - The last non-deferred tool and the last system block carry `cache_control: { type: 'ephemeral', ttl: '1h' }`. The two rolling message breakpoints keep the default 5m TTL, satisfying Anthropic's longer-TTLs-before-shorter ordering rule. Tests: messagesApi.spec.ts now at 65 tests (was 59); adds dedicated `modelSupportsExtendedCacheTtl` and `isExtendedCacheTtlEnabled` suites covering every gate explicitly.
* Fix runInTerminal sandbox wording tests * x * Use terminal fallback for customization file reads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )