[pull] main from microsoft:main#1419
Merged
Merged
Conversation
typeof null === 'object' is true in JavaScript, so a null value in the configuration tree passes the existing type guard and Object.keys(null) throws 'Cannot convert undefined or null to object'. Add explicit null check to the guard condition. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The `relayCreationTimeoutMs` override in `TestableSSHRemoteAgentHostMainService` was missing its `protected` modifier, causing the mangler to promote it to `public` and fail the `compile-build-with-mangling` step with: ERROR: Protected fields have been made PUBLIC. This hurts minification and is therefore not allowed. Re-add `protected` to the override declaration to keep the field's visibility consistent with the base class and satisfy the mangler.
…ngler The field `relayCreationTimeoutMs` is `protected` in the base class. The test subclass `TestableSSHRemoteAgentHostMainService` had overridden it without an explicit access modifier, making it implicitly `public`. The mangler correctly rejected this as it hurts minification. Adding `protected` back satisfied the mangler but caused a TS2445 error since the test was assigning to the field directly on an instance, which is illegal for `protected` members outside the class hierarchy. Fix by adding a narrow public setter `setRelayCreationTimeoutForTest` in the test subclass. The field stays `protected`; the setter provides a legitimate public entry point for tests. Signed-off-by: Nikola Hristov <Nikola@PlayForm.Cloud>
Fixes #316140 Let's try with `table` as the default initially but we can switch to `hide` is we prefer
…ion swap (#316229) Replace the spread-based `IActiveSession` construction with an `ActiveSession` class that delegates all `ISession` property accesses to the underlying session object. This keeps the active session in sync with live session state instead of holding a stale shallow copy. When a session is replaced via `onDidReplaceSession`, pass `force: true` to `setActiveSession` so the active session is always fully rebuilt — even when the session ID remains the same. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…types (#316231) Replace the eslint-disabled import of LOCAL_SESSION_ENABLED_SETTING from the providers layer with ISessionsManagementService.getAllSessionTypes(). The local harness is now registered when any provider offers a session type with id 'local', and removed when it disappears. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fix window controls in agents window
sessions: improve AI readiness of skill and instructions - Restructure SKILL.md: remove duplicated content, add mandatory pre-change reads (coding guidelines, source-code-organization), add 'When to read' column to spec table, make valid-layers-check mandatory, add common pitfalls section - Enhance sessions.instructions.md: add architecture overview, internal layer diagram, core services table, key development patterns (menus, context keys, observables), and learnings section - Remove window isolation references (not applicable) - Remove Development Recipes from skill (already in SESSIONS.md) - Add explicit 'Before Making Any Changes' mandatory reads block to ensure coverage in all harnesses (not just VS Code Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fix window title in agent title bar status widget
…n` (#316249) * Wait longer to get settings in `_developer.getConfigurationInformation` * CCR feedback
…4-fe1a3002d94d23e4 fix: guard against null in doRemoveFromValueTree (fixes #316034)
* AgentCustomizationItemProvider for both local and remote * update * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * update * only sync plugin & extension customizations * fix tests --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Detect Agent Host alternate buffer commands * wordings * keep agent host shell held after early command result
* Support model pinning * Cleanup some hardcoded auto logic
…ixes #316033) (#316042) The pages array excludes page 0 (pre-resolved via firstPage), so accessing this.pages[pageIndex] is off by one — pageIndex 1 should map to pages[0]. This caused 'Cannot read properties of undefined (reading promise)' when resolving extensions on any page after the first. Co-authored-by: vs-code-engineering[bot] <122617954+vs-code-engineering[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fixes #311734 Set COPILOT_AGENT=1 in agent terminal sessions so CLI tools can detect they are running inside an AI agent and adapt their output (e.g. JSON instead of ANSI, disable interactive prompts, skip animations). This follows the same pattern as other agents (CLAUDE_CODE, CURSOR_AGENT, etc.). Co-authored-by: Megan Rogge <meganrogge@Megans-MacBook-Pro.local> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fix: restore protected modifier on relayCreationTimeoutMs in test helper
Enable output renderers for code blocks in chat
Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 7.5.5 to 7.5.8. - [Release notes](https://github.com/protobufjs/protobuf.js/releases) - [Changelog](https://github.com/protobufjs/protobuf.js/blob/protobufjs-v7.5.8/CHANGELOG.md) - [Commits](protobufjs/protobuf.js@protobufjs-v7.5.5...protobufjs-v7.5.8) --- updated-dependencies: - dependency-name: protobufjs dependency-version: 7.5.8 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Add improved markdown front matter rendering
Update context keys for editor commands
* Remove model picker category * fix compile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )