[pull] main from microsoft:main#1485
Merged
Merged
Conversation
The autorun in WorktreeCreatedTaskDispatcher previously disposed its own store via _sessionDisposables.deleteAndDispose, which could synchronously remove the entry while the autorun was still mid-run and allow a re-entrant _trackSession call to install a fresh autorun that fires again. - Switch to reader.dispose() so the autorun tears itself down cleanly without racing _sessionDisposables bookkeeping, preventing the worktreeCreated tasks from being dispatched more than once per session. (Commit message generated by Copilot)
Co-authored-by: Copilot <copilot@github.com>
* Avoid leaking event listeners in notebook search * Remove redundant disposals.
…9068) Awaiting promises before passing them to Promise.race serializes the competitors and defeats the race. Pass the timeout and onDidChangeInput promises directly so the timeout can fire while waiting for input. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
…19172) Parse the per-TTL breakdown from Anthropic's usage.cache_creation object (present in message_start across CAPI/Anthropic 1P, Bedrock InvokeModel, and Vertex AI) and emit two new measurements on response.success: - promptCacheCreation1hTokenCount: 1h-TTL writes (2x base input rate) - promptCacheCreation5mTokenCount: 5m-TTL writes (1.25x base input rate) Enables exact per-row COGS attribution for the chat.anthropic.promptCaching.extendedTtl A/B experiment without inferring rates from arm assignment. The new fields live on a nested anthropic_cache_creation? object on APIUsage.prompt_tokens_details, namespaced to make the provider-specificity explicit at the type level. Other providers leave it undefined; telemetry uses optional chaining so missing values drop cleanly from the row.
* Propagate error from zipfile to the caller of read() * PR feedback
* fix: memory leak in extension actions * Reuse runAction helper to dispose actions --------- Co-authored-by: Dmitriy Vasyura <dmitriv@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )