feat(netbird): support external relay config and verify relay in e2e (#83)#87
Open
mikkeldamsgaard wants to merge 1 commit intomainfrom
Open
feat(netbird): support external relay config and verify relay in e2e (#83)#87mikkeldamsgaard wants to merge 1 commit intomainfrom
mikkeldamsgaard wants to merge 1 commit intomainfrom
Conversation
…83) Add `server.config.relays.{addresses, credentialsTTL}` and a dedicated `server.secrets.relaySecret` reference so users can point peers at an external relay deployment when the public relay hostname differs from the management hostname. When `relays.addresses` is empty (default), the embedded relay continues to run and reuse `authSecret` exactly as before. The chart's e2e script now runs `netbird status --detail` inside a registered peer pod and asserts the relay shows `is Available`, so the exact symptom in #83 ("relay client not connected") becomes a CI failure rather than a silent runtime regression. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server.config.relays.{addresses, credentialsTTL}and a dedicatedserver.secrets.relaySecretso peers can be pointed at an external relay deployment when the public relay hostname differs from the management hostname. Whenrelays.addressesis empty (default), the embedded relay continues to run and reuseauthSecretexactly as before — no behavior change for existing installs.ci/scripts/netbird/e2e.shto runnetbird status --detailinside a registered peer pod and assert the relay showsis Available, so the exact symptom from Relay server not working #83 ("relay client not connected") becomes a CI failure rather than a silent runtime regression.RELAY_SECRETenv wiring (external secret vs. auto-generated), and the auto-generated Secret'srelaySecretkey.Refs #83.
Test plan
helm lint charts/netbirdpasseshelm unittest charts/netbird— 247 / 247 pass, 11 snapshots intactmake e2e-sqlitepasses locally end-to-end (kind cluster up → chart installed with PAT seed → 2 peer pods registered withaccessible_peers=1→Relay is Availableconfirmed insidenetbird-peer-1)🤖 Generated with Claude Code