Add Flatpak and desktop and metainfo.xml file#536
Add Flatpak and desktop and metainfo.xml file#536kevinsmia1939 wants to merge 7 commits intoKitware:masterfrom
Conversation
mleotta
left a comment
mleotta
left a comment
There was a problem hiding this comment.
This looks reasonable to me, but I don't know much about Flatpak. Please respond to the inline comments. They are mostly suggestions.
| can be colored from the source imagery. | ||
| </p> | ||
| </description> | ||
| <url type="homepage">https://github.com/Kitware/TeleSculptor</url> |
There was a problem hiding this comment.
It might be better for this to be https://telesculptor.org/, which is the new homepage we've launched recently. It links back to the Github page.
| Terminal=false | ||
| Type=Application | ||
| Icon=org.telesculptor.TeleSculptor | ||
| Categories=Qt;Science;DataVisualization; |
There was a problem hiding this comment.
We might consider adding ImageProcessing, Geoscience, and 3DGraphics, maybe also AudioVideo;Video. There are other categories that might fit too.
There was a problem hiding this comment.
Does TeleSculptor also have audio, so it can be include in AudioVideo category?
Nevermind, AudioVideo have to follow Video anyway.
There was a problem hiding this comment.
Yeah, no audio, but it sounds like to include Video you also need AudioVideo as a super category.
| @@ -0,0 +1,88 @@ | |||
| app-id: org.telesculptor.TeleSculptor | |||
There was a problem hiding this comment.
I think this is okay. Another option might be com.kitware.TeleSculptor, but I'm not sure what rules are used to determine what this name should be.
There was a problem hiding this comment.
Since the new homepage is telesculptor.org, would not the org.telesculptor.TeleSculptor be better?
There was a problem hiding this comment.
Probably. I'm not suggesting that this needs to be changed, I'm just trying to figure out how these ids are chosen and what the conventions are. You said you've done this for other Kitware open source tools right? Do those follow the same conventions?
There was a problem hiding this comment.
The naming follow "reverse DNS"
https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#file-naming
Usually, it would be the main website of the software, like org.paraview.ParaView.
Now, the name must have 2 dots. So the name usually repeats. if it is too short.
But of course, it think it is better for you to pick the name you prefer.
There was a problem hiding this comment.
org.telesculptor.TeleSculptor seems correct then, especially if ParaView is org.paraview.ParaView since that is a highly analogous example.
|
@mleotta Sorry for hijacking this PR, but would you or anyone else from Kitware have write access to the TeleSculptor repo on Flathub? Kevin is doing a fantastic job maintaining apps, and so I imagine you wouldn't need to do anything specific, but one of Flathub principles is upstream involvement. |
|
@barthalion I'm happy to be involved, but have not worked with Flathub yet myself. @kevinsmia1939 has been pushing for Flatpak support and I'm happy to let him continue to do so, but if you need me to have access somewhere, just let me know what I need to do. |
3 participants
These files are instructions to build TeleSculptor as Flatpak.
#425