feat: add completion and hover language-feature providers#5
Open
jlee-kitware wants to merge 1 commit into
Open
feat: add completion and hover language-feature providers#5jlee-kitware wants to merge 1 commit into
jlee-kitware wants to merge 1 commit into
Conversation
jlee-kitware
force-pushed
the
language-feature-providers
branch
from
6fea1ee to
171adb0
Compare
Add `completion` and `hover` props to the Editor widget. Each names a trame @trigger that receives (code, line, column) and returns results; the component registers Monaco completion/hover providers that call the trigger over the existing websocket and map the normalized results onto Monaco. The consumer writes only Python: no client-side JavaScript and no access to the Monaco instance are required. - completion items: {label, kind, detail, documentation, insertText} - hover: a markdown string, a list of strings, or {contents: [...]} - positions: line is 1-based, column is 0-based - requests honor Monaco's CancellationToken; providers are disposed on unmount and re-registered when the language changes - adds a jedi-backed Python example under example/language-features
jlee-kitware
force-pushed
the
language-feature-providers
branch
from
171adb0 to
a6ece94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
completionandhoverprops to the Editor widget. Each names a trame @trigger that receives (code, line, column) and returns results; the component registers Monaco completion/hover providers that call the trigger over the existing websocket and map the normalized results onto Monaco. The consumer writes only Python: no client-side JavaScript and no access to the Monaco instance are required.this is not an LSP as what is proposed in the language-servers branch. as such we can register other complete handlers like a live-state contextual complete as demonstrated in the example. This capability is complementary to the LSP capability.