fix(app): change _async_display to public method for google-colab usage#25
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 1
Lines ? 4
Branches ? 0
========================================
Hits ? 4
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Thibault-Pelletier
force-pushed
the
google-colab
branch
from
a407cc2 to
1a5d3a3
Compare
- Update the visibility of the _async_display method to public and let users change the iframe width / height on call - Move the logic to trame-client AbstractLayout
Thibault-Pelletier
force-pushed
the
google-colab
branch
from
1a5d3a3 to
d48a4cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to Kitware/trame-client#63
@jourdain trame-client is a dependency for trame-common but isn't listed in the pyproject.toml.
Should I update that with a min version?