chore(ResliceCursorWidget): fix example#3543
Open
Jo-Byr wants to merge 1 commit into
Open
Conversation
finetjul
reviewed
Jul 6, 2026
finetjul
left a comment
Member
There was a problem hiding this comment.
Can you please explain what the problem is/was ?
Contributor
Author
I don't know why this fixes the problem. As explained in the top comment, I noticed the example's content was present in the page, but under a blank div. I searched for a working example with a similar structure (one that uses document.createElement), which is DepthTest, and tested it. |
Collaborator
|
@Jo-Byr just remove the div with id "vtk-root" it was not used https://github.com/Kitware/vtk-js/blob/master/Documentation/scripts/build-examples.mjs#L66 |
eb0e1e7 to
190858a
Compare
finetjul
requested changes
Jul 7, 2026
Remove unused vtk-root element from generated examples HTML
190858a to
20dbb96
Compare
finetjul
approved these changes
Jul 8, 2026
finetjul
left a comment
Member
There was a problem hiding this comment.
LGTM.
Please edit your PR opening comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Some examples have been broken since the switch to lil-gui, the example of ResliceCursorWidget is one of them. The widgets were displayed below a white div.
Results
The example is now correctly displayed.
Changes
Added a container element, by taking inspiration from DepthTest example.
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting
Tested with