Improve macos support #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tly in python-wheel.cmake.
…possible fallback to macosx_deployment_target usage.
MisterGC
force-pushed
the
improve-macos-support
branch
8 times, most recently
from
bd9a27e to
70f24eb
Compare
…h a sample project.
MisterGC
force-pushed
the
improve-macos-support
branch
from
70f24eb to
b1d399e
Compare
1 task
josephbirkner
requested changes
Oct 29, 2025
Collaborator
josephbirkner
left a comment
josephbirkner
left a comment
There was a problem hiding this comment.
Hmm, what problem are we solving here? Could you please test this with mapget as well? The delocate-path tool is well-established and it is there to also change the RPATH in packaged dependency libs. Potentially a regression, since packaged dependencies of dependencies will not be found anymore. Maybe we can add a shared lib dependency with a dependency to the test wheel?
josephbirkner
approved these changes
Oct 29, 2025
Collaborator
josephbirkner
left a comment
josephbirkner
left a comment
There was a problem hiding this comment.
Wow 👍 Good to merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves macOS wheel building by automating library dependency handling with
delocate, eliminating the need for manual post-processing scripts while properly supporting transitive dependencies (e.g., OpenSSL → libcrypto). The build process now automatically invokesdelocate-pathduring CMake builds, ensuring all bundled libraries use correct@loader_pathrpaths. No API changes required - existing projects only need topip install delocate.